Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to declare support for uv compiled requirements.txt #34569

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update documentation to declare support for uv compiled requirements.txt #34569

wants to merge 8 commits into from

Conversation

beagold
Copy link

@beagold beagold commented Sep 12, 2024

Why:

Accompanies dependabot/dependabot-core#10040

What's being changed (if available, include any code snippets, screenshots, or gifs):

Aim is to declare in the documentation that uv is partially supported when updating compiled requirements.txt files.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Sep 12, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@beagold beagold mentioned this pull request Sep 12, 2024
Open
5 tasks
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable
code-security/dependabot/ecosystems-supported-by-dependabot/supported-ecosystems-and-repositories.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review dependabot Content related to Dependabot and removed triage Do not begin working on this issue until triaged by the team labels Sep 12, 2024
@nguyenalex836
Copy link
Contributor

@beagold Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836
Copy link
Contributor

@github/docs-content Please ensure @jonjanego has reviewed / approved this PR before this is merged - thank you! 💛

@github github deleted a comment from 12Kirk2v121BTMST Sep 13, 2024
@github github deleted a comment from 12Kirk2v121BTMST Sep 13, 2024
@github github deleted a comment from 12Kirk2v121BTMST Sep 13, 2024
@github github deleted a comment from 12Kirk2v121BTMST Sep 13, 2024
subatoi
subatoi previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beagold — this looks good from a Docs perspective. I've left some small things for you and @jonjanego to take a look at.

Even though I'm approving this, it won't be merged just yet, but I see no major blockers so I'm leaving the approval to make the process smoother when we're ready to merge 👍

data/reusables/dependabot/supported-package-managers.md Outdated Show resolved Hide resolved
data/reusables/dependabot/supported-package-managers.md Outdated Show resolved Hide resolved
data/reusables/dependabot/supported-package-managers.md Outdated Show resolved Hide resolved
@nguyenalex836
Copy link
Contributor

@beagold Howdy! 👋 Would you be able to take a peek at the suggestions / comments above? 💛

@beagold
Copy link
Author

beagold commented Sep 27, 2024

@beagold Howdy! 👋 Would you be able to take a peek at the suggestions / comments above? 💛

I am so sorry! Thanks for the ping, it seems like GitHub didnt send me the push notification otherwise

@beagold @subatoi
Fix broken link
f9e667e 
Co-authored-by: Ben Ahmady <[email protected]>
subatoi
subatoi approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb left review comments

@jonjanego jonjanego jonjanego requested changes

@subatoi subatoi subatoi approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beagold @nguyenalex836 @jonjanego @zanieb @subatoi